Manu Sridharan

Results 671 comments of Manu Sridharan

> And if that goes away, does the entire `build` element go away too? Yes, I think we could delete the entire `build` element in this `pom.xml`. > > We'd...

Is the `:com.ibm.wala.ide:eclipse` task running as part of the Maven CI job? Right now this is what runs before the Maven build: https://github.com/wala/WALA/blob/74bab0d97d36d9dc99a86c19659cf8ff0579fd8a/travis/before-install-maven#L3 Maybe we need to add the `eclipse`...

Maven is doing compilation via Tycho: https://travis-ci.org/github/liblit/WALA/jobs/679906421#L447 So it doesn't work like a standard Java compilation. It may well be using `build.properties` and `MANIFEST.MF` to find the dependencies, at least...

Sigh. Nothing with Tycho is easy. I am busy but when I get time I can try to take a look. We can always try sticking in the WALA jars...

> Turn that frown upside-down, @msridhar! 🙃 I figured out the missing dependency issue in [612aad2](https://github.com/wala/WALA/commit/612aad2b4589211207bc367d016a18bf0d51f8dd). Woohoo! I guess it was a good idea to change the output directory 😄...

This plugin to run Maven from Gradle might be useful: https://github.com/dkorotych/gradle-maven-exec-plugin/blob/master/README.md Haven’t tried it, just wanted to mention it

@MadhuNimmo many regression tests are failing. Can you take a look and fix?

Hi @reddr, not clear to me this is a bug. We've had discussions for a while about cleanly separating a "core" package from code that specifically supports Java bytecode, but...

yeah we should probably clean this up. Error Prone's [ReferenceEquality check](http://errorprone.info/bugpattern/ReferenceEquality) catches similar issues.

Unfortunately, not much. I'd suggest looking at this code and copy-pasting from it to get started (it builds a call graph for an APK): https://github.com/wala/WALA/blob/447e536f51626bc4d1de1f416c18f67d5df41b37/com.ibm.wala.dalvik/src/test/java/com/ibm/wala/dalvik/test/callGraph/DalvikCallGraphTestBase.java#L115 I'll try to add some...