Manu Sridharan

Results 671 comments of Manu Sridharan

Ok no problem! One thing is if you control the code generator, you can tweak it to generate [downcasts](https://github.com/uber/NullAway/wiki/Suppressing-Warnings#downcasting) or other [warning suppressions](https://github.com/uber/NullAway/wiki/Suppressing-Warnings) so you can still use NullAway on...

> Making progress using your trick, so we'll see how it comes out :) Awesome! :) Regarding your `create` example, yeah, this would be good to handle too. If you...

Great, so glad you got things working! And thanks again for all the reports. We'll dig through them more in the new year. Regarding the query methods, I think we...

> Joy, integrated into my project. There are 50 targeted suppressions and neutral impact to code readability. Thanks for all of the hard work :) Awesome! Thanks for all your...

Question, do we get a warning on code like the following, which doesn't have records? ```java class X { boolean equals(Object o) { return false; } static boolean foo() {...

I agree we can do a special case for records for now (though if I need to implement it, it will be a few weeks). More broadly, I wonder if...

> Running [`EqualsMissingNullable`](https://errorprone.info/bugpattern/EqualsMissingNullable) over the Uber code base could help assess the impact. Thanks! Presumably this check could be used to auto fix existing issues as well. Might be worth...

Thanks for the suggestion! We'll keep this in mind. We're going to re-think our suppressions story around inner classes in the near future

Thanks for the report, @fprochazka. The only other relevant thing I can think of are [external init annotations](https://github.com/uber/NullAway/wiki/Configuration#external-init-annotations), but that doesn't apply here since there is no special annotation on...

Thanks for the report! My first thought as a quick fix is to just treat `@ParametricNullness` as if it were the same as `@Nullable`. That should certainly fix this issue....