Sean Gilligan

* Add a private boolean 'supportsDeterministic' to handle the no HD support state * Make 'chains' non-nullable * Simplify code where now possible

A quick sketch of a possible near-future modular architecture

8

This is a rough sketch/proposal of some of the architectural directions we have been discussing.

EXPERIMENT: Use picocli subcommand feature

1

This is mostly broken and the code is messy, but the following commands are working: * `wallettool help` * `wallettool help help` * `wallettool help dump` * `wallettool dump --wallet=path/to/test-spv.wallet...

Add functional/integration testing with Bitcoin Core in RegTest mode

7

I believe we can improve our testing by adding functional tests that have **bitcoinj** communicate with **Bitcoin Core**. This probably would be implemented by creating a new Gradle subproject (perhaps...

wallettool: Refactor, Improve UI and documentation (meta-issue)

9

This issue is a meta-issue to tie together various proposals to improve `wallettool`. In my opinion there are _three categories_ of improvements that are needed and also _related_. So this...

WalletTool/Wallet: add BIP43 support to WalletTool

10

Wallet: add createDeterministic overloads with KeyChainGroupStructure parameter WalletTool: Add --structure option and use it to configure KeyChainGroupStructure

DumpedPrivateKey,BIP38PrivateKey: inline PrefixedChecksummedBytes

1

This is a draft because: a. `PrefixedChecksummedBytes` is not removed yet b. The tests in `PrefixedChecksummedBytesTest` should be replicated in `DumpedPrivateKey` & `BIP38PrivateKey`.

walletfx: Refactor with AppDelegate, WalletApplication, etc.

6

* Introduce `AppDelegate` class for delegating JavaFX `Application` * Move most of existing `Main` to `WalletApplication` * `WalletTemplate` extends `WalletApplication` and specifies `"main.fxml"` and `"wallet.css"` * Create abstract class `MainWindowController`...

Block: refactor constructors and factory methods

1

* Move construction code from *NetParams into Block * Create private constructors for special purposes * Remove duplication in factories / constructors * Mark apparently unused deserializing constructs as @Deprecated...

Work-in-progress: Replace usages of Guava Immutable collections with JDK unmodifiable

3

* Mostly replacing usage of Guava Immutable collections * A few other Guava Collections replacements (Set.newHashSet())