bitcoinj icon indicating copy to clipboard operation
bitcoinj copied to clipboard

DumpedPrivateKey,BIP38PrivateKey: inline PrefixedChecksummedBytes

Open msgilligan opened this issue 3 years ago • 1 comments

This is a draft because:

a. PrefixedChecksummedBytes is not removed yet b. The tests in PrefixedChecksummedBytesTest should be replicated in DumpedPrivateKey & BIP38PrivateKey.

msgilligan avatar Jun 26 '22 17:06 msgilligan

I think that's too much of separation. It makes sense to handle both standards for encoded private keys within one class hierarchy. However, at some point I'd rename the base class.

schildbach avatar Jun 26 '22 19:06 schildbach

I think this is now obsolete?

schildbach avatar Aug 14 '22 09:08 schildbach

I think this is now obsolete?

Yes. Closed.

msgilligan avatar Aug 17 '22 21:08 msgilligan