Sean Gilligan

Transaction: add CF-returning waitForConfirmations()

4

This was inspired by and would simplify PR #2542

TransactionBroadcast::future() does not complete when run against local RegTest mode

1

Change e3513964ed2fcbd0f5e9edb6e160094061a46225 in 0.15.8 prevents the following (Groovy) code from running: ``` Transaction tx = new Transaction(params) tx.addOutput(amount, rpcAddress) SendRequest request = SendRequest.forTx(tx) wallet.completeTx(request) // Find an appropriate input, calculate...

Transaction/TransactionOutput: move methods to TransactionBag

1

* Move methods from Transaction/TransactionOutput that take a wallet/TransactionBag parameter to TransactionBag * Deprecated existing methods * Update existing code to use new calls There are two outstanding issues (which...

Output Descriptor generation and parsing for deterministic keychains

7

This is a first step to adding "output descriptors". There are unit tests that verify correct generation of descriptors for `P2PKH` and `P2WPKH` HD keychains.

Coin: add ofBTC(long coins) factory method

7

* Add overload `Coin.ofBTC(long coins)` * Add overload `static long btcToSatoshi(long coins)` * Use the new `Coin.ofBTC` where appropriate to improve readability Draft: depends on PR #2511 (though it doesn't...

This PR is dependent upon PR #2362. You can see the rendered README here: https://github.com/bitcoinj/bitcoinj/blob/56eb3f06b8a1f807d62e8cf6dc024f7da0c72415/README.adoc

Add WalletIF interface for Wallet

1

* Remove most direct dependencies on Wallet * Create WalletIF and supporting classes in org.bitcoinj.core.wallet Major remaining issue is splitting out pieces of Proto This is a proof of concept...

I added P2TR support here somewhat naively. But all tests pass!

This is one path towards moving Address to `o.b.base`. (Another path is to reduce dependencies in `NetworkParameters` and move it to `o.b.base`) This gets really messy because there are unit...

This needs additional work, especially the creation of some kind of AddressFactory interface, but refactoring to an Address interface and getting unit tests to pass turned out to be easier...