mrpt_slam icon indicating copy to clipboard operation
mrpt_slam copied to clipboard

Published 20 hours ago • verified publisher icon mrpt-ros-pkg

Set parameters

Open JakubHazik opened this issue 6 years ago • 2 comments

Is possible set parameters for example sigma distribution of lidar beams or resolution of a map? I talk about mrpt_icp_slam_2d package

JakubHazik avatar Apr 18 '18 15:04 JakubHazik

I will improve parametrization of all nodes.

Logrus avatar Mar 19 '19 21:03 Logrus

Great! @Logrus : Just in case, take a look at the regression I inadvertidly introduced a few days ago trying to avoid pointers, here: https://github.com/mrpt-ros-pkg/mrpt_navigation/commit/76db0c7f2e885e72dec3e1c4c41a568ade089d89#diff-eafe347e79a69eca21d60da0a53ce9e7L79

It was fixed here: https://github.com/mrpt-ros-pkg/mrpt_navigation/commit/75b539d8e9d7478b727dc89da80432bedbfd5615

I can't remember if more nodes use the same approach of inheriting the Parameters struct (Node ==> Library), but it would be better split into two structs, as in my second commit above.

jlblancoc avatar Mar 19 '19 23:03 jlblancoc