Marc Rousavy

Results 1816 comments of Marc Rousavy

thanks for the report. Yea, in V3 (https://github.com/mrousavy/react-native-mmkv/pull/656) I removed `TypedArray` in favor of simplifying it to `jsi::ArrayBuffer`. That gives you more granular control over what bytes you want to...

Interesting, thanks for your PR! Changes look good, but do people actually use Vitest in RN apps?

Hi. Please share the photo. Orientation is not implemented yet, see https://github.com/mrousavy/react-native-vision-camera/issues/1891

Can you try changing this value here to see what works? https://github.com/mrousavy/react-native-vision-camera/blob/e8ae11e30b4fb4e25a38fa589b27229c18c03171/package/android/src/main/java/com/mrousavy/camera/core/CameraSession.kt#L230 Try just ```kt val orientation = Orientation.PORTRAIT ``` or Orientation.LANDSCAPE_LEFT or whatever - just let me know which...

@stefan-schweiger I see - what's the sensor orientation of that Camera Device on your phone then? ```kt val sensorOrientation = cameraCharacteristics.get(CameraCharacteristics.SENSOR_ORIENTATION)!! ``` Can you tell me the value of this?...

Yea, Samsung for some reason always suck at building consistent Camera APIs. I had to add a special workaround for 60 FPS on Samsung, and apparently Orientation is the same...

@isinuyk yea this is the thing - this is the function that needs careful adjustment to correctly respect Orientation in all cases - on Huawei, Samsung, Google phones, as well...

Interesting research! Sucks that we have to rotate photos afterwards, as this definitely reduces performance.