Marc Rousavy comments

Results 1813 comments of


                                            Marc Rousavy

Feature Request: iOS and Android dispose implementations

> For example, Java's implementation of finalization has been removed and is unreliable. This is the exactly same in JS. That's why I'm hesitant to implement this. Objects can live...

Feature Request: iOS and Android dispose implementations

oh - I implemented this already in https://github.com/mrousavy/nitro/pull/770 😅

fix: Improve text line height calculation to properly align text on iOS

nice!

Adds `format-filepath` to customize the filepath of `.clang-format`

Hey - is this PR still being worked on?

🐛 Orientation in output not correct when camera facing up/down.

Actually this is a valid issue @maintenance-hans. I think this is because `.face-up` and `.face-down` are just casted to `portrait` here: https://github.com/mrousavy/react-native-vision-camera/blob/77e98178f84824a0b1c76785469413b64dc96046/package/ios/Core/Types/Orientation.swift#L69-L70 This is a bit tricky, since we technically...

🐛 Orientation in output not correct when camera facing up/down.

I can fix it, but I don't have the free time to work on this. Sponsors welcome

🐛 Orientation in output not correct when camera facing up/down.

@githistory can you DM me on Twitter or send me an email for details? I think I do have time in February to build this & release it.

MmkvLogger creates log strings even if logging is disabled

Sure it is possible - I'd gladly accept PRs that change/fix this.

Failed to create TFLite interpreter from model when passing core-ml argument

correct

[Android] Loading Model from local file with GPUDelegate fails to load

yea sorry the bot isn't very smart