Marc Rousavy
Marc Rousavy
Hey - thank you for your PR, this is great! One small change - can you change `enableAutoKeyExpiration` to be a getter + setter boolean property, instead of a function?...
ohhh - I'm sorry I misunderstood that then. I thought it was a simple boolean! Hmm, let me think about this, not sure if I want this to be a...
Hey - so two thoughts: 1. I don't like the way every `set` function now has an extra branch. To me, it looks much more complex than before. I want...
Thank you - I really appreciate the contribution - but I want to avoid merging something that overcomplicates the codebase, because that makes it harder to contribute or improve the...
> The code below it is working since it is using takeSnapshot, shouldn't work the same for takePhoto? Those two funcs are implemented very differently - takeSnapshot uses the preview...
Depending on how you process the thumbnail you might also need to handle orienation yourself.
Fixed in 4.6.3
Interesting. I'm guessing this is a codegen bug
fixed in https://github.com/mrousavy/react-native-mmkv/pull/754 🔥