Marc Rousavy

Results 1813 comments of Marc Rousavy

Hey - nice work on your module & thanks for using Nitro! :) Hm, maybe it might be a good idea to report this bug to the Swift compiler; https://github.com/apple/swift

The error is the same right? Then yes, I'd report this as a Swift compiler bug

Yea, it's a Swift compiler bug. The `StringHolder` workaround works, but is a bit ugly. I'm not sure if I should do that automatically in Nitrogen, or if I should...

Spent a long time investigating this bug. Finally found a fix; https://github.com/mrousavy/nitro/pull/830

This is funny - because your error message; ``` Function type mismatch, declared as '@convention(method) (@in_guaranteed __ObjC.std.__1.optional>) -> @out __ObjC.std.__1.function Void)>' but used as '@convention(method) (@in_guaranteed __ObjC.std.__1.optional>) -> @out __ObjC.std.__1.function...

Hey - can you try upgrading Nitro and Nitrogen to the latest versions and checking if you still have the same issue?

> ```ts > interface User { > name: string > } > > interface Profile { > name: string > } > ``` Could it be that the compiler thinks...

> no matter those interfaces struct are same or not. But we use multiple interfaces here in the tests; https://github.com/mrousavy/nitro/blob/4647a6b6b0208848c561421ea663323db1e56819/packages/react-native-nitro-test/src/specs/TestObject.nitro.ts#L38-L72 ... and they are all building & passing fine.

In #650 I added a test for this. ```ts interface TestObject extends HybridObject { // ... twoOptionalCallbacks(value: number, first?: (value: number) => void, second?: (value: string) => void): void }...