Results 231 comments of Matt Reiferson

These changes seem fine, ready to land this @ploxiln?

Ahh, good catch, thanks! Need to circle back around to deprecating all of the old functionality across `nsqd` and official client libs.

It looks like the part of the docs that @marians is referring to is in regards to sync vs. async _message handling_. That definitely could benefit from some expansion.

@jehiah should we also bump `max_attempts` to `25`?

Do we need to provide a param to disable archiving when we already encourage users to subclass and override the method?

yep, this should be part of the public API, thanks for reporting!

@kenshiro-o hi Ed :smile: I've taken over maintenance of this repo - what do we need to do here to get this in?

@virtuald hey, I've taken over maintenance of this repo - is this ready to go in?

Cool, thanks - want to touch base with @danielhfrank before I move forward with merging things, I know he's been maintaining some changes too.