pynsq icon indicating copy to clipboard operation
pynsq copied to clipboard

CLS command in pynsq

Open kolyanu4 opened this issue 10 years ago • 2 comments

I found in TCP protocol spec message CLS but in pynsq there is no method for this message.

CLS

Cleanly close your connection (no more messages are sent)

CLS\n

Success Responses:

CLOSE_WAIT

Error Responses:

E_INVALID

kolyanu4 avatar Mar 26 '14 15:03 kolyanu4

yep, this should be part of the public API, thanks for reporting!

mreiferson avatar Mar 26 '14 16:03 mreiferson

+1, but piling on for a full disconnect/close operation on a Reader. CLS nsqd connections, close nsqlookupd conns, and clean up Tornado callbacks.

I half assed this last week, but it turned out to be trickier than I thought.

crossjam avatar Jul 20 '14 21:07 crossjam