pynsq icon indicating copy to clipboard operation
pynsq copied to clipboard

reader: by default, archive failed messages to disk

Open jehiah opened this issue 8 years ago • 4 comments

This is a follow up to #134 and changes the default behaviour of Reader.give_up() to be less surprising by writing messages that are "given up on" to disk instead of dropping them completely.

jehiah avatar Nov 23 '15 14:11 jehiah

RFR @mreiferson. I'd love any naming comments you have, and if you can think of an obvious way to disable this (an additional parameter of archive_abandoned_messages=True ?)

jehiah avatar Nov 23 '15 14:11 jehiah

@jehiah should we also bump max_attempts to 25?

mreiferson avatar Nov 23 '15 18:11 mreiferson

Do we need to provide a param to disable archiving when we already encourage users to subclass and override the method?

mreiferson avatar Nov 23 '15 18:11 mreiferson

what're we doing on this one?

mreiferson avatar Feb 14 '16 22:02 mreiferson