Jan Berdajs

Results 135 comments of Jan Berdajs

Also, would there be a security issue if I allowed users to publish to a channel with the same key that is used to "sign" into a channel (that hash)?...

Is this ever going to be made? Would be nice to have this option, as I would prefer to run the nodejs server.

Yes I think it only affects `table_backend`. See failing spec: https://github.com/mrbrdo/mobility/blob/mrbrdo/spec/mobility/plugins/active_record/query_spec.rb#L114

@shioyama can you comment on this failing spec?

Possibly the last question from my OP? `Is there at least a single place / setting in Mobility where it would be possible to add the additional conditions for the...

That's exactly what I did: https://github.com/mrbrdo/spree_mobility/blob/main/lib/spree_mobility/core_ext/mobility/backends/active_record/table/mobility_acts_as_paranoid_decorator.rb But was hoping for a cleaner way :)

See this failing spec: https://github.com/mrbrdo/mobility/blob/mrbrdo/spec/mobility/backends/active_record/table_spec.rb#L112 Also, I'm not sure that a fallback for `en-XX` should always include `en`, even if it's explicitly not specified (such as `fallbacks({ :'en-US' => 'de-DE',...

@shioyama I think the fix could be as simple as https://github.com/shioyama/mobility/pull/572 I did some testing with my app (Spree) and it seems its working well. My failing spec is now...

@shioyama could you take a look? You can update the failing few specs since they seem to be testing internal logic (which I think should not be tested, or said...

@shioyama did you manage to take a look?