Jan Berdajs

Results 135 comments of Jan Berdajs

@rafalcymerys guys can you merge this in faster, it's been 6 months? why does this need a major version bump? (4.5)

@rafalcymerys that is very good to hear, I have some more commits to contribute, after the existing PRs are sorted, I will do the rest. Hope the PR review will...

@rafalcymerys @aleksandarpetrushev can confirm this issue with latest Spree version. As noted the issue seems to be caused by a bug in ActiveRecord (TouchLater). Do you plan to fix this...

@aleksandarpetrushev I think the best way to fix this right now is to disable TouchLater https://github.com/spree/spree/pull/11796

I don't want to be rude, but these are not email templates and should be not labeled as such. They don't work in most of major email clients. This is...

@banagale yes, but an "email template" shouldn't require that, it should be adapted for emails, which this isn't. And obviously the code from the inlining tool is awful looking.

@banagale I will give you the point about inlining css. However even after doing that, you are using rgba colors (for no obvious reason), which it seems do not work...

Well I can confirm it is 100% a locale-related issue for me. For example, I tried setting up the locale that was being forwarded through SSH to my server, and...

@janko when bundle installing my app on Debian 10 (Buster), I had to install libvips to be able to successfully bundle install. From Gemfile.lock, the only obvious reason for that...