Callahan Kovacs

Results 169 comments of Callahan Kovacs

Good advice. I checked the github logs and confirmed the tests are executing as expected: ``` google:ubuntu-18.04-64:tests/spread/providers/legacy/host-env-passthrough google:ubuntu-18.04-64:tests/spread/providers/legacy/lxd-env-passthrough google:ubuntu-18.04-64:tests/spread/providers/legacy/lxd-managed-environment google:ubuntu-18.04-64:tests/spread/providers/legacy/lxd-prime-then-try google:ubuntu-18.04-64:tests/spread/providers/legacy/lxd-try google:ubuntu-18.04-64:tests/spread/providers/lxd-basic google:ubuntu-18.04-64:tests/spread/providers/lxd-build-info google:ubuntu-18.04-64:tests/spread/providers/lxd-mknod google:ubuntu-18.04-64:tests/spread/providers/lxd-type-base google:ubuntu-20.04-64:tests/spread/providers/legacy/host-env-passthrough google:ubuntu-20.04-64:tests/spread/providers/legacy/lxd-env-passthrough google:ubuntu-20.04-64:tests/spread/providers/legacy/lxd-managed-environment google:ubuntu-20.04-64:tests/spread/providers/legacy/lxd-prime-then-try google:ubuntu-20.04-64:tests/spread/providers/legacy/lxd-try...

I've been experiencing the same behavior since upgrading to Kubuntu 23.10 for `Wired connection 2` being deactivated. I've verified that I don't experience actual network disconnectivity, just an annoying notification...

I ended up using `git ls-files` to accomplish the same result: https://github.com/canonical/starbase/commit/0f6657d77982007f7ced73f61dc0f08010655091#diff-ef2cef9f88b4fe09ca3082140e67f5ad34fb65fb6e228f119d3812261ae51449R119-R128

https://github.com/canonical/craft-parts/pull/727

Something has broken between `testtools` and [pytest 8.2.0](https://github.com/pytest-dev/pytest/issues/12263) for the legacy unit tests: ``` ____________ ERROR collecting tests/legacy/unit/test_file_utils.py _____________ .tox/test-legacy-py310/lib/python3.10/site-packages/testtools/testcase.py:241: in __init__ test_method = self._get_test_method() .tox/test-legacy-py310/lib/python3.10/site-packages/testtools/testcase.py:696: in _get_test_method return getattr(self,...

> Not sure why the codespell CI job would fail on legacy stuff here. Should this be rebased maybe? Yeah, codespell got updated and started flagging more words. It should...

This should be fixed because we bundle git in https://github.com/canonical/snapcraft/pull/5149

Fixes via #4793 and https://github.com/canonical/craft-application/pull/343

@lengau - do you know why craft-application is splitting the project name here? https://github.com/canonical/craft-application/blob/099d82fb6a57a24e801ccfed38f32ce3b0a627b8/craft_application/services/remotebuild.py#L179

Closing because this has been completed via the pydantic 2 refactor: https://github.com/canonical/snapcraft/pull/4955