Manuel Pégourié-Gonnard

Unfortunately this now has a conflict in tf-psa-crypto. Suggested resolution: 1. Update the associated crypto PR in order to fix the code style issues - quite probably rebase it too,...

You've not missed anything in the merge strategy, it is indeed supposed to point the the current tip of development. And I think it does: on the [github diff page](https://github.com/Mbed-TLS/mbedtls/pull/10077/files#diff-f3e318e4acded4ea7022b742fc031d9fca93e80cdbd85380cb2575dc8a809d35)...

With https://github.com/Mbed-TLS/TF-PSA-Crypto/pull/189 merged, the pointer can be updated here. The PR also needs rebasing to resolve the conflict... with the crypto pointer :)

@gilles-peskine-arm Do you have specific examples in mind? How do we find these workarounds that we can now remove?

I think this is mostly covered by https://github.com/Mbed-TLS/mbedtls/issues/10087 and https://github.com/Mbed-TLS/TF-PSA-Crypto/issues/220 - at least the part mentioned in the title. Regarding the details: - NIST-KW is handled by https://github.com/Mbed-TLS/TF-PSA-Crypto/pull/180 - XTS...

This has been done. `cipher.h` is no longer a public header, it has now been moved to a `private` subdirectory of the include path.

> I've been using `mbedtls_pk_get_type()` to implement `mbedtls_pk_get_key_type()` for public keys (whoops). Is that okay or should I be doing something else? Ah, thanks for noticing! Ideally you should be...

This has a conflict but also a CI failure that looks real, considering all 3 CIs have the same single component failing.

Hi and thanks for your contribution! > New code based on an older PR, fixed to latest coding styles. Thanks for the update! Could you provide a link to the...

Hi Hani! Thanks for your interest in Mbed TLS and for getting in touch. Indeed relying on internal functions and private fields in structures is fragile as those are susceptible...