Manuel Pégourié-Gonnard

Hi Hani, Thanks for discussing the general strategy, that's very helpful. I tend to agree with your analysis and favour the "medium" approach as well. > Simple: Provide only a...

Thank you for your report and the detailed analysis! Indeed this looks like a silly bug in the benchmark program's `myrand()` function. I think the following version of `myrand()` should...

> The values cycle every 256 calls of rand(). I don't think they do. We're taking the low 8 bits of the output of `rand()` but that doesn't affect the...

Ok, thanks for the details @jbsgh ! I had tried on my system, but I guess my build of glibc must be using a more sophisticated RNG by default. It...

Sure, but at some point it's better to just stop using `rand()` (which comes with almost no guarantees from the standard) and move to something better, as we were planning...

Thanks for creating a 3.6 backport! However, I should point out that 3.6 is an LTS branch and normally only receives fixes (bugs & vulnerabilities), while this looks like a...

Thanks for your contribution! However it needs to include an automated non-regression test, as part of `test_suite_x509parse`. See https://mbed-tls.readthedocs.io/en/latest/kb/development/test_suites/ and please feel free to ask questions if anything's not clear...

@jbsgh As indicated in our [contributing guidelines](https://github.com/Mbed-TLS/mbedtls/blob/development/CONTRIBUTING.md#license-and-copyright) we require a `Signed-off-by:` line in every commit in order to indicate compliance & agreement with our contribution requirements. Can you amend your...

(Once that's done, please remind me to kick the CI.)

Thanks for the reminder! I've just started the jobs, results should be back in a few hours.