mbedtls icon indicating copy to clipboard operation
mbedtls copied to clipboard

Add challenge password to CSR Development

Open rgqsch opened this issue 3 months ago • 2 comments

Description

New code based on an older PR, fixed to latest coding styles. This will add a challenge password to the CSR which might be needed by some SCEP servers

PR checklist

Please remove the segment/s on either side of the | symbol as appropriate, and add any relevant link/s to the end of the line. If the provided content is part of the present PR remove the # symbol.

  • [ ] changelog provided In this PR
  • [ ] development PR provided | In this PR
  • [ ] TF-PSA-Crypto PR not required because: Not changed
  • [ ] framework PR provided Mbed-TLS/mbedtls-framework#219
  • [ ] 3.6 PR provided #10432
  • tests provided In this PR

Notes for the submitter

Please refer to the contributing guidelines, especially the checklist for PR contributors.

Help make review efficient:

  • Multiple simple commits
    • please structure your PR into a series of small commits, each of which does one thing
  • Avoid force-push
    • please do not force-push to update your PR - just add new commit(s)
  • See our Guidelines for Contributors for more details about the review process.

rgqsch avatar Oct 01 '25 06:10 rgqsch

Hi and thanks for your contribution!

New code based on an older PR, fixed to latest coding styles.

Thanks for the update! Could you provide a link to the older PR? In case it already had some review history.

mpg avatar Oct 03 '25 11:10 mpg

Hi and thanks for your contribution!

New code based on an older PR, fixed to latest coding styles.

Thanks for the update! Could you provide a link to the older PR? In case it already had some review history.

There were 2 old PR, those were never merged (#7843 and #7444 ). This is a complete rewrite trying to be more generic: In mbedtls_x509write_csr adding a generic attributes field, in stead of a dedicated csr_password field.

rgqsch avatar Oct 05 '25 13:10 rgqsch