Matt Palmer

Results 144 comments of Matt Palmer

Creating a connection pool with custom connector

By the looks of it, you can (probably) get what you need by creating your `driver.Connector`, passing that to `sql.OpenDB()`, and then passing the resulting `sql.DB` to `sqlx.NewDB()`.

Adding in link to PingMesh exporter to docs

Tagging random people into your PR is abusive behaviour. Please stop it.

npm error could not determine executable to run

I've got no idea what the problem here is. Any thoughts, @bcheidemann ?

npm error could not determine executable to run

I don't have a strong preference for or against asking to take over the NPM action-validator package. Not knowing the ecosystem, I can't say whether that sort of thing is...

npm error could not determine executable to run

You make a persuasive point. I agree documentation improvements are sufficient for now.

pre-commit fails on multiple changed files

By default, I _think_ the pre-commit script is supposed to invoke the native `action-validator` binary. However, that supports multiple files (there's even a [test case](https://github.com/mpalmer/action-validator/tree/main/test/009_multi_file) to prove it), and your...

pre-commit fails on multiple changed files

Thanks for the feedback. I'll see what I can do to make it more obvious that the npm version is very, very Not Recommended.

`permissions` in a job are incorrectly flagged

Well, first off, well done figuring out what the JSON schema validator output is actually talking about. :grin: My first thought was that this might be a newer feature than...

`permissions` in a job are incorrectly flagged

Aha! You've cracked the case. That was [added to the schema](https://github.com/SchemaStore/schemastore/commit/f79c4c83dce72927a416a8b3fc72a8fcf8f262f0) more recently than what we're currently using. A schema bump will fix this; PR if you like, or I'll...

`permissions` in a job are incorrectly flagged

This was fixed by #96.