Matt Palmer
Matt Palmer
I'd be happy to merge a PR or two implementing either or both of these features.
Thanks for the bump, @award28, this slipped off my radar. I've put this on my list to review tomorrow; to answer your question: > Should we still maintain the run...
Hey @award28, do you have the bandwidth to push this through to completion, or shall @bcheidemann and myself finish it off and land it?
Any chance this could be considered for re-opening? I've got a use case where I can't do direct comparisons of the strings, and so sort keys are the only available...
tl;dr: encryption. Deep nerd dive: I can't do direct comparisons of the strings because they're encrypted, and the service performing the comparison doesn't have the key to decrypt the strings...
> If & when ICU4X adds APIs and code for sort keys, it would be nice for it to generate the same sort keys as ICU4C/J Undoubtedly compatibility with ICU4C/J...
Hey @Jarcho, are you up for getting this rebased / refactored for merge? If not, lmk and I'll have a crack at it. I'd like to see this lint land,...
Given this hasn't moved in years, I suspect the general consensus is that `Ok(thing?)` is generally preferred over `this.map_err(From::from)`, and I have to agree. The `?` approach is less characters,...
This is a solid change. I've started using it in a project of mine and it's working great.
My comments from #6 regarding 8e6b17b are appropriate here also. The brace placement on c35c45e is... unique. Far better to stick with the existing style, though.