mark padgham

Results 322 comments of mark padgham

Thanks @rsbivand, above commit bypasses that expectation for the moment until we completely deprecate sp. Should pass your revdep tests from here on regardless.

Thanks @rsbivand, i'm working on the resubmission this very moment :+1:

@rsbivand New version on CRAN now. Thanks for always paying attention and helping!

Thanks to @jmaspons for fixing this via PR linked above.

@jmaspons yes, i am very keen for something to happen with this - it's already been open way too long, which ain't good :scream: I should also be able to...

Yeah, for sure @Mashin6, and great that you responded so promptly after such a long time - thank you! I'll get back to asap - hopefully in a few days...

@Mashin6 There've been a few changes to `opq.R` recently. Would you please be able to merge those within your branch, and then push the updated version to this PR? Thanks!

@jmaspons What are your thoughts on this issue? Mock tests are currently only in these four files: 1. Single mock call only which could be replaced: https://github.com/ropensci/osmdata/blob/503674690ab3763cf5ea48e699c3466849c2e24f/tests/testthat/test-unname.R#L15-L17 2. In [`test-features.R`](https://github.com/ropensci/osmdata/blob/main/tests/testthat/test-features.R),...

@rubak I had the same issue on Archlinux, and found at least one cause. Your configure script hard-codes the C++ compiler to g++ and over-rides any local preferences for clang....

... not necessarily. The devtools workflows are complicated in the way they respect local compiler flags. I suspect also that your configure is entirely overwriting local flags, which devtools does...