addons-code-manager

addons-code-manager copied to clipboard

Infinite 404 errors in Compare view when comparing two versions from a filepath that's not available in either versions

1

### Describe the problem and steps to reproduce it: 1. Open the following compare page: https://code.addons.allizom.org/en-US/compare/1002949/versions/2478166...2478215/?path=js%2Fbackground_script.js 2. Notice the errors in the page and in the browser console ### What...

AlexandraMoga

Warning: Failed prop type: Invalid prop `hunk.changes[95].type` of value `normal-eofnl` supplied to `Hunk`, expected one of ["delete","insert","normal"].

1

I loaded http://localhost:3000/en-US/compare/494431/versions/1532144...1689906/ locally and saw this warning in the console logs, so I filed this issue. ┆Issue is synchronized with this [Jira Task](https://mozilla-hub.atlassian.net/browse/ADDCDMGR-47)

willdurand

Followup for https://github.com/mozilla/addons-code-manager/issues/1623#issuecomment-649533840 STR: 1. Load a compare page in code manager which contains modified lines 2. for such a [file](https://code.addons.allizom.org/en-US/compare/1004704/versions/2477733...2477734/?messageUid=fc3aca5dedc7479bada68ddfac5dde52&path=about.css) the overview has 36 lines yet the diff shows...

ioanarusiczki

Reviewer tools link should redirect to the unlisted review page of an unlisted addon

5

The add-on has only unlisted versions. STR: 1. From rev tools load the review unlisted page of an add-on such as https://reviewers.addons-dev.allizom.org/en-US/reviewers/review-unlisted/20af87ee710b4ad4b142 2. Open the code manger viewer from this...

ioanarusiczki

Allow CodeView to accept a single `file` prop instead of 3 individual props

1

This is a follow-up to https://github.com/mozilla/addons-code-manager/pull/1498. `CodeView` accepts [some props](https://github.com/mozilla/addons-code-manager/blob/master/src/components/CodeView/index.tsx#L64-L68) which are properties of a `VersionFile`. #1498 introduced yet another of those, the `isMinified` prop. It seems like it might...

bobsilverberg

This is a follow-up to #1454, which introduced a `PerformanceObserver` into the `App` component. I was unable to figure out how to get code coverage for the body of the...

bobsilverberg

The file in the old version should load when going from compare to the browse page

6

Followup for https://github.com/mozilla/addons-code-manager/issues/1421 STR: 1. Go to https://code.addons-dev.allizom.org/en-US/compare/7560/versions/1252898...1688247/?path=install.rdf 2. Click the Compare Versions button and then click the Browse page for the old version Expected result: the page should load...

ioanarusiczki

This comes from a discussion with @willdurand, following a discussion that he had with @wagnerand. We are currently truncating files based on the size of the content of a file,...

bobsilverberg

The non-highlighted lines look different - Browse versus Compare view

2

STR: 1. Go to line of code which is not highlighted (has more than 500 chars) in Browse view https://code.addons-dev.allizom.org/en-US/browse/494431/versions/1689906/?path=jquery-ui%2Fjs%2Fjquery-1.7.1.min.js 2. Using the Compare Versions button view the same file...

ioanarusiczki

Ability to skip certain file types when using the keyboard shortcuts

1

This is based on feedback from the meeting we had today to discuss the code manager. There was a desire expressed to be able to configure the file tree to...

bobsilverberg