addons-code-manager icon indicating copy to clipboard operation
addons-code-manager copied to clipboard

Reviewer tools link should redirect to the unlisted review page of an unlisted addon

Open ioanarusiczki opened this issue 4 years ago • 5 comments

The add-on has only unlisted versions.

STR:

  1. From rev tools load the review unlisted page of an add-on such as https://reviewers.addons-dev.allizom.org/en-US/reviewers/review-unlisted/20af87ee710b4ad4b142
  2. Open the code manger viewer from this page
  3. After the file viewer loads click the "Reviewer Tools" link to go back to rev tools

Expected result: https://reviewers.addons-dev.allizom.org/en-US/reviewers/review-unlisted/20af87ee710b4ad4b142 loads

Actual result: https://reviewers.addons-dev.allizom.org/en-US/reviewers/review/20af87ee710b4ad4b142 loads

Notes: On the listed review page there's a link to the unlisted review page (as a workaround). This issue is reproducible on dev with FF75(Win10).

┆Issue is synchronized with this Jira Task

ioanarusiczki avatar Apr 13 '20 13:04 ioanarusiczki

We need to use the channel to build the url back to Reviewer Tools. This is just for the link in the upper left-hand corner.

bobsilverberg avatar Apr 17 '20 13:04 bobsilverberg

This issue has been automatically marked as stale because it has not had recent activity. If you think this bug should stay open, please comment on the issue with further details. Thank you for your contributions.

stale[bot] avatar Oct 21 '20 17:10 stale[bot]

@wagnerand Should we prevent stalebot from closing this?

bobsilverberg avatar Oct 21 '20 17:10 bobsilverberg

@bobsilverberg If it's easy to fix and we find time to work on it some day it would be great. It's a minor annoyance but there are workarounds, since you can get from one reviewer tools channel page to another.

wagnerand avatar Oct 21 '20 17:10 wagnerand

It seems like an easy fix. We are just waiting for a kind contributor to take it on.

bobsilverberg avatar Oct 21 '20 18:10 bobsilverberg