Craig P. Motlin
Craig P. Motlin
Sorry that was a typo, I forgot the logarithm. One implementation is to keep a min heap of fixed size k. Insert every (item, count) pair into it and remove...
We had a request years ago to create OSGi bundles, and we created the update site that you found. I don't think any of the contributors are too familiar with...
Hi @shanman190, yes I'm running `mvnd` which is pretty similar to running `mvn --threads 1C`. The rewrite plugin is explicitly marked thread-safe: https://github.com/search?q=repo%3Aopenrewrite%2Frewrite-maven-plugin%20threadSafe&type=code
Because of the nature of this as a concurrency problem, I don't run into it frequently and haven't reproduced it with `mvn --threads` but they are extremely similar and I...
It's a bit hard to review due to the size. I'm looking for the new overrides you mentioned. I know it's a pain to split up but I'd recommend separating...
I landed a similar change for non-primitive collections recently: https://github.com/eclipse/eclipse-collections/pull/1583 This was easy to implement (though not easy for @donraab to review!) because I was able to use Openrewrite. For...
What about the annotation? Is it possible to avoid it? Even compile-time-retention annotation dependencies show up as dependencies when searching sites like mvnrepository.com. We'd prefer to show up as having...
I don't remember the PR very well anymore but in #1175 @donraab you went through some effort to create META-INF/services without adding a dependency on auto-service. I have [another project](https://github.com/motlin/liftwizard)...
The other thing which can make this kind of change easier is searching for similar methods and putting the new method in the same classes. For example, putting this right...
@gargsuraj12 feel free to submit a PR. #1734 was opened against this issue but doesn't actually include any changes.