Craig P. Motlin
Craig P. Motlin
I wasn't familiar with the ClassGraph library before. I like how using it makes it possible to delete so much code from FileUtils. To me, it seems like introducing ClassGraph...
~EclipseCollectionsCodeGenerator.generate() delegates to `EclipseCollectionsCodeGenerator.sourceFileExists(outputFile)` before rendering a file. So if a hand-written boolean version exists, we won't generate code for the template anyway.~ I read the test and now understand...
My overall impression is that I like Classgraph and how it helps reduce code. I'm not sure about the test because it's going to run slowly and doesn't seem like...
Sorry for the delay. Looking at this now and I want to check my assumptions. This test would: - be a new test - execute CoreMithraDbDefinitionGenerator#execute - generate into a...
RichIterable and LazyIterable must not extend Collection. Implementing stream() across the board isn't easy. FastList would need a stream similar to ArrayList's. Same for UnifiedSet and HashSet. For other collection...
collectKeysAndValues() isn’t fluent. You call it on the target map, not the source. It’s a strange method. In my use-case, the original Map keys don’t implement equal/hashcode, and I want...
I think so. It might even be a good first issue.
It's in the description above. ```java MapIterable collectKeysUnique(Function2
I'm leaning toward: let's include unique in the name and let's throw.
I feel like the conversation may be most productive if we focus here: > the reason why I consulted this documentation is that I wondered how EC's Predicate differed from...