Craig P. Motlin

Results 152 comments of Craig P. Motlin

This one has been open for a while and just adds test coverage. Any objections to landing it?

Named parameters would be especially helpful together with varargs. I have [a recipe for running maven](https://github.com/liftwizard/klass/blob/0.4.0/.just/maven.just#L8) with four parameters. ```justfile mvn MVN=default_mvn TARGET=default_target PROFILES=default_profiles *FLAGS=default_flags: ``` The FLAGS argument is...

Thank you @Riya-Sharma12. I assigned this issue to you. Feel free to submit a pull request with "Fixes #1680" in the commit message. I saw you asked about joining the...

@vaibhaaavvv have you followed the steps in https://github.com/eclipse/eclipse-collections/blob/master/CONTRIBUTING.md? If so, what step fails, and with what error message?

@vaibhaaavvv those look like IDE errors. Do you get any errors when you run the maven build?

Sounds like a problem where the IDE doesn't recognize all the generated sources folders. I think you're using the Eclipse IDE, is that right?. Most of the contributors here use...

It makes sense to me. I'd like to get @mohrezaei's opinion too since there was a similar change in #1661 that raised performance concerns.

The implementation is probably good, but the implementations of StackIterable.takeWhile() have no test coverage.

LGTM now, probably just needs the two commits squashed into one.

> As helpfully pointed out in [#239](https://github.com/openrewrite/rewrite-logging-frameworks/pull/239) this should instead be covered by https://docs.openrewrite.org/recipes/java/logging/slf4j/slf4jlogshouldbeconstant > > Hope that helps! I'm trying to understand why similar code lives in two places....