Craig P. Motlin

Results 152 comments of Craig P. Motlin

I believe this is technically a security vulnerability, but I'm also kind of open to it. A malicious user could deserialize some custom bytes into a subclass of an unmodifiable...

I'm looking around in Guava, and they don't even have concrete classes. Unmodifiable wrappers are all abstract. I don't fully understand why the concrete classes must have hidden visibility, but...

You know how ParallelIterable has container-specific sub-interfaces? Like ParallelListIterable. For a long time, I've wanted to add container-specific sub-interfaces to LazyIterable. It's a big project though and I haven't had...

We should also fix the generics on ofMap(), probably in a major version.

Starting on a major release is a commitment to not do any release for a while. I thought 9.1.0 and 9.2.0 went well. On the other hand, most of the...

The ultimate way to reduce code duplication would be to say our mutable maps are all `new UnifiedMapWithHashingStrategy(HashingStrategies.defaultStrategy())` but we're worried this would hurt performance a bit. I wouldn't worry...

MutableOrderedMap is an interface. Maybe you mean OrderedMapAdapter?

Specialized lazy iterables are a great idea and we should add them, but they aren’t necessary for this optimization. We’re probably just missing an override of minBy. On Mon, Mar...

This issue is tricky. I'll share what I've learned so far. First, you're right of course, bag.asLazy().someMethod() iterates over each occurrence for most methods, which is inefficient. AbstractBag has lots...

If you haven't yet, take a look at RichIterableTestCase#RichIterable_iterationOrder and the subclasses HashBagNoIteratorTest. I mention it because distinct views are fine, but they shouldn't be necessary. You identified a performance...