Moritz
Moritz
Closing as the [dart-lang/logging](https://github.com/dart-lang/logging) repository is merged into the [dart-lang/core](https://github.com/dart-lang/core) monorepo. Please re-open this PR there!
It seems like you found the fix already, adding `breaking` to the `fail_on` list in the settings.
It does pass now, as the version is correct. Can you point to the invocation which incorrectly passed?
Why should it be failing? [The comment](https://github.com/dart-lang/build/actions/runs/11150849769/attempts/1#summary-30992945328) says it needs a minor version bump, which was made. What am I missing?
@devmil - Widening the return type seems to be a minor breaking change at the moment - should it be a major breaking change instead?
Hm. But the `version` part of the report seems to indicate that the version should only be bumped from `4.1.0` to `4.2.0`, or am I overlooking something?
Also, I thought `"type": "minor"` indicates that this warrants only a minor version change, or what does it mean?
Sounds good - and the `version` key of the report should then also suggest `5.0.0`, correct?
Yes, the `needed` field is [the one being parsed](https://github.com/dart-lang/ecosystem/blob/bed43c312bc22d0c6f86c6d32e00235314c2a460/pkgs/firehose/lib/src/health/health.dart#L195).
Hm, that sounds like the API tool it is working correctly after all. The health PR check currently tests against the repository checkout, it's an interesting question if it should...