Moritz

Results 345 comments of Moritz

@jtattermusch I couldn't find any specs for this feature. Do specs for this exist, or is there a reference implementation?

Thanks for reporting this. This does not seem to be working as expected.

Nice catch @antoinepemeja. @lukepighetti, does this solve your issue?

Closing as solved - please re-open if this doesn't work after all.

`dart pub get` is failing because of `package:test`, which has a pubspec entry: ```yaml # Use a tight version constraint to ensure that a constraint on matcher # properly constrains...

Closing as the [dart-lang/matcher](https://github.com/dart-lang/matcher) repository is merged into the [dart-lang/test](https://github.com/dart-lang/test) monorepo. Please re-open this PR there!

Thanks for the PR! Sounds good at first glance, but I will check the [specs](https://github.com/grpc/grpc/blob/master/doc/keepalive.md) and take a look at this PR next week.

LGTM in general, I filed a PR on your fork to address the failing test. Let me know what you think. Probably has to be slightly rebased after #732 landing.

> @mosuem Your changed test looks good to me. I rebased the PR on the current main branch. So I guess this PR is ready to be merged :) It...