Moritz comments

Results 345 comments of


                                            Moritz

Allowing ErrorHandler to remove sensitive information

This would be a breaking API change, as `GrpcErrorHandler` is part of the public API. So this PR would need a major version rev and changelog entries. What is the...

Convert TODOs to use URLs instead of issue numbers

There are multiple issues here: 1. Using URLs instead of issue numbers 2. Using a consistent style in TODOs 3. Unifying TODOs in native/dart-lang/Dart+Flutter I have no opinion on 1....

Making sure we're testing `test_data/**/test`

Do we want to run those tests? I thought we didn't. I use them for manual testing during development only.

Streaming issue on web only

> It's the simple file upload chunking code that works fine on native platforms There are two different protocols, `grpc` and `grpc-web`, which are only related by name. > 1....

[intl4x] Issue with Native Assets Library Resolution in Dart Executables

So you mean the structure which is generated is ``` build/ lib/intl4x.so app.exe ``` But what you actually have to manually do to make it work is ``` lib/intl4x.so build/...

[intl4x] Issue with Native Assets Library Resolution in Dart Executables

I will try to reproduce this with the newest versions of `native_*` cc @dcharkes

[test_reflective_loader] Use test groups instead of combining names

/gemini review

[test_reflective_loader] Use test groups instead of combining names

@DanTup sorry for using your PR to test the Gemini code review feature ;)

[test_reflective_loader] Use test groups instead of combining names

> Although the "critical" issue above is not so good But the signature is actually this - or what am I missing? ```dart _Test( super.name, this.function, { required super.location, required...

ICU4X 2.0 Dart bindings questions

Also, is there a list of possible timezone values exposed somewhere? The parser must know what to parse for, right? It would be easier for users to select from a...