Moritz

Results 345 comments of Moritz

> It always adds the asset (dynamic library) to the build output `native_toolchain_c` [solves that](https://github.com/dart-lang/native/blob/4eaec5a18977e215b3d37a6293564d1911137cef/pkgs/native_toolchain_c/lib/src/cbuilder/cbuilder.dart#L106) with an optional parameter in the `run` method. So I think it should be adaptable....

> Hmm doesn't work Yeah I saw that the tests didn't run for #874, should be fixed now.

It should, [here](https://github.com/dart-lang/i18n/releases/tag/intl4x-icu-v.0.9.2-artifacts) is the list of precompiled targets. The build hook of the package should download the right one, and everything should just work(*). (*) It is currently in...

The `hook/build.dart` and `hook/link.dart` scripts are run automatically when running `dart --enable-experiment=native-assets build bin/main.dart`. Hopefully this will be out of experimental soon. Same holds for Flutter, see also https://github.com/flutter/flutter/issues/129757.

Running the full health bot locally is a bit involved, but I will check if the CI tests on the ecosystem repo can reproduce this.

Closing in favor of #1479. This PR can still be taken into consideration when rethinking the storage format.

The date time patterns are autogenerated from the Unicode CLDR database. Date parsing is unfortunately very fragile.

I don't know what the best strategy is - parsing is inherently fragile exactly because of cases like this. Maybe the logic of parsing could be special-cased for arabic parsing....

Yes, PRs here are merged automatically by copybara after being approved in g3.