Moody Salem
Moody Salem
The EIP is now CFI: https://github.com/ethereum/execution-specs/blob/master/network-upgrades/mainnet-upgrades/shanghai.md#eips-considered-for-inclusion Would love to see this in revm and subsequently forge so users can start playing with it
> I'm not sure that I understand the till metaphor. Is there an implementation in Uniswap v4 that could be used as reference? It's a till, like a cash register,...
> >As long as the transient state you validate at the end is related only to that caller's ID, it's plenty safe. > > > > Can you elaborate on...
specifically this problem https://github.com/danfinlay/eth-ens-namehash#security-warning
Copying them over is not ideal since we still only represent a single version and it requires manual work, ideally there is a documentation site for each NPM package version...
would rather a pr that makes the interface use v2 quoter if possible
actually, maybe we should just run the whole thing on pull requests in a mode that does not write to the github repo (which is pretty much integration testing)
@yonggewang can you elaborate? does the code not match the proof?
I'm not sure what is meant by 'wrong', can you be specific about what part of [the proof](https://uniswap.org/audit.html#org16ece60) is incorrect?
@livnev do these comments make sense to you?