deploy-v3 icon indicating copy to clipboard operation
deploy-v3 copied to clipboard

Published 20 hours ago • verified publisher icon Uniswap

Deploy the quoter as well as the quoter v2

Open wbl opened this issue 2 years ago • 4 comments

The Uniswap frontend relies on the original quoter interface and will not work on a testnet with only quoter v2.

Fixes Issue #6

wbl avatar Feb 16 '22 22:02 wbl

@NoahZinsmeister I can't figure out how to add you as a reviewer. Could you please take a look at this enhancement? The big diff is to the yarn lockfile, which I don't really understand why it happened as I'm pretty new, but I can probably figure out how to fix it.

wbl avatar Feb 17 '22 02:02 wbl

@moodysalem @asood123 do either of you have time to take a look?

wbl avatar Feb 17 '22 23:02 wbl

would rather a pr that makes the interface use v2 quoter if possible

moodysalem avatar Feb 17 '22 23:02 moodysalem

I agree that would be preferable, but I'm not entirely sure what the status of deployment and the address are on all the chains, which is why I didn't end up trying that approach.

It does seem like the only difference is some additional return data, so it wouldn't be a huge PR to make, even for someone with as minimal frontend skills as me.

wbl avatar Feb 17 '22 23:02 wbl