governance-seatbelt icon indicating copy to clipboard operation
governance-seatbelt copied to clipboard

test: integration testing for proposal checks

Open moodysalem opened this issue 2 years ago • 1 comments

running it locally is good, but is manual testing, and checks can break

would be good to have some automated tests that verify the results of checks on individual proposals

e.g.: for the verify etherscan check, pass in some proposal data that calls a target with unverified code, and separately pass in a proposal that calls verified code, and check the resulting output of the check

these tests are integration testing because they rely on external apis

moodysalem avatar Sep 30 '21 18:09 moodysalem

actually, maybe we should just run the whole thing on pull requests in a mode that does not write to the github repo (which is pretty much integration testing)

moodysalem avatar Jan 10 '22 19:01 moodysalem