Jonathan Moody

The complaints from clang include -Wunreachable-code, -Wunused-but-set-variable plus a missing declaration for lseek(). ``` (lbry-venv-3.9) swdev1@Jonathans-Mac-mini lbry-sdk % /Library/Developer/CommandLineTools/usr/bin/clang++ --version Apple clang version 13.1.6 (clang-1316.0.21.2.5) Target: arm64-apple-darwin21.5.0 Thread model: posix...

Support symbolic amount/bid=everything which spends all funds from selected account/wallets.

14

Fixes: https://github.com/lbryio/lbry-sdk/issues/1628 I know this is lacking in tests for the higher-level functionality like Transaction.pay(), claim_create(), claim_update(), support(). I'm most concerned about claim_update(). However, I haven't been able to get...

Bump to Python 3.9 attempt 2.

5

Based on work by @eukreign in branch py39. I am still not sure what issues in the tests are truly due to Python upgrade vs. pre-existing timing issues. I have...

various tests: hub.herald.session - ERROR - TCP server failed to listen on 127.0.0.1:50002 :OSError(98, "error while attempting to bind on address ('127.0.0.1', 50002): address already in use")

2

https://github.com/moodyjon/lbry-sdk/actions/runs/3094377560/jobs/5007689165 ``` 4439 test_source_filter (integration.claims.test_claim_commands.ClaimSearchCommand) ... 2022-09-21 00:47:00,475 - asyncio - WARNING - Executing took 0.504 seconds [4440](https://github.com/moodyjon/lbry-sdk/actions/runs/3094377560/jobs/5007689165#step:11:4441) 2022-09-21 00:47:01,495 - elasticsearch - WARNING - GET http://localhost:9200/_template/783bfa0b44764850859fa3e1d4f4daf4claims [status:404 request:0.003s] [4441](https://github.com/moodyjon/lbry-sdk/actions/runs/3094377560/jobs/5007689165#step:11:4442)...

test_unhandled_sqlite_misuse: AssertionError: False is not true : this test failing means either the sqlite race conditions have been fixed in cpython or the test max_attempts needs to be increased

1

https://github.com/moodyjon/lbry-sdk/actions/runs/3091793824/jobs/5002309726 ``` sqlite3 2.6.0/python 3.7.13 (default, May 4 2022, 08:45:32) did not raise SQLITE_MISUSE within 80000 attempts of the race condition ``` ``` 478 ====================================================================== [479](https://github.com/moodyjon/lbry-sdk/actions/runs/3091793824/jobs/5002309726#step:9:480) FAIL: test_unhandled_sqlite_misuse (tests.unit.wallet.test_database.TestSQLiteRace) [480](https://github.com/moodyjon/lbry-sdk/actions/runs/3091793824/jobs/5002309726#step:9:481)...

test_spec_example: send_to_address_and_wait(address, 400.0) hangs test

2

Similar to lbryio/hub#98, but no reconnect is involved. Extra hub tracing for notifications in moodyjon/hub was NOT enabled, so we don't see much detail. https://github.com/moodyjon/lbry-sdk/actions/runs/3062810249/jobs/4944196405 ``` 3514 test_spec_example (integration.takeovers.test_resolve_command.ResolveClaimTakeovers) ......

Miscellaneous fixes for intermittent test failures

1

Fixes #3660 Fixes #3658 Fixes #3662 Also hub version is bumped to latest which includes a fix for: https://github.com/lbryio/hub/issues/92 Will remove 6a2246c088f8447860be1978c780210a3fcb0828 as it's a temporary change to allow push...

test_reorg_change_claim_height: lbry.wallet.orchstr8.node - ERROR - failed to start lbcwallet

4

https://github.com/moodyjon/lbry-sdk/runs/8281334226?check_suite_focus=true I might have seen this in other tests in the past... Could it be infrastructure? No error message from `lbcwallet` regarding why it could not start. ``` test_reorg_change_claim_height (integration.takeovers.test_resolve_command.ResolveAfterReorg)...

test_sync_with_encryption_and_password_change : "zlib.error: Error -3 while decompressing data: incorrect header check" instead of InvalidPasswordError

2

https://github.com/moodyjon/lbry-sdk/runs/8281333893?check_suite_focus=true ``` ====================================================================== [3608](https://github.com/moodyjon/lbry-sdk/runs/8281333893?check_suite_focus=true#step:11:3609) ERROR: test_sync_with_encryption_and_password_change (integration.blockchain.test_wallet_commands.WalletEncryptionAndSynchronization) [3609](https://github.com/moodyjon/lbry-sdk/runs/8281333893?check_suite_focus=true#step:11:3610) ---------------------------------------------------------------------- [3610](https://github.com/moodyjon/lbry-sdk/runs/8281333893?check_suite_focus=true#step:11:3611) Traceback (most recent call last): [3611](https://github.com/moodyjon/lbry-sdk/runs/8281333893?check_suite_focus=true#step:11:3612) File "/home/runner/work/lbry-sdk/lbry-sdk/lbry/testcase.py", line 145, in run [3612](https://github.com/moodyjon/lbry-sdk/runs/8281333893?check_suite_focus=true#step:11:3613) self.loop.run_until_complete(maybe_coroutine) [3613](https://github.com/moodyjon/lbry-sdk/runs/8281333893?check_suite_focus=true#step:11:3614) File "/opt/hostedtoolcache/Python/3.7.13/x64/lib/python3.7/asyncio/base_events.py", line 587, in...

test_transaction_show: AttributeError: 'dict' object has no attribute 'id'

1

test_transaction_show needs some kind of fix to wait for the transaction to be available. The sleep(0.2) is not a guarantee that it's in the wallet DB. In this case, even...