Jonathan Moody

Results 101 comments of Jonathan Moody

OK, so I've learned about GitHub actions & workflows, and I'm running that to do testing server-side on the forked repository.

Getting a message in the Actions tab for moodyjon/lbry-sdk repository: > GitHub Actions is currently disabled for your account. Please reach out to GitHub Support for assistance. Have filed a...

In my environment (MacOS arm64) I have had partial success running integration tests and success running generate_json_api.py. Ready for review. No response on ticket: https://support.github.com/ticket/personal/0/1603371

GitHub support ticket was resolved, and I can run tests server-side again. Runs are failing, and I'm awaiting the test fix: https://github.com/lbryio/lbry-sdk/pull/3608

> @moodyjon thanks for continuing to work on this, can you rebase on latest master, there were some fixes related to running tests that will improve your test runs Done....

@eukreign Do you have your own test runners or are you using plain GitHub runners? Reason I ask is I sometimes get odd timeout or off-by-one errors using the free...

> Leave the requirement for `amount` as positional argument, this is the case currently. Is this a safety concern, or concern about callers using positional arguments? Call sites are still...

Implemented the generic amount (int|string) suggestion, and it uncovered places relying on amount being a definite value (int). Fixed these by pulling the amount from the actual "txo" constructed. (8b2c284d7a8a015e0edadc2e39ee8633a5960aaf...

Demote to draft status as I plan to unbundle some changes in subsidiary PRs.