Kev

Results 13 comments of Kev

@andrii-lysenko, on my phone (Android + Chrome) your latest change didn't do anything. The Message app opens but there's no predefined message. I don't think it's a blocker at this...

Thanks @chrisbliss18. It seems that the rebase fixed the issue.

Thanks @bindlegirl! > I wasn't able to reproduce the problem on trunk you mentioned either. It's been fixed by other PRs I've recently merged.

> I replaced return true with return false as instructed, and couldn't get the form to display. @sergeymitr, I realize my instructions may have been confusing. The condition should be...

Sorry @sergeymitr, I noticed an error and had to push another commit: https://github.com/Automattic/jetpack/pull/36089/commits/b3aaf6be0f73508ba898699a799a278437e4ff28

I just noticed some JS tests are failing because they reference the deleted file.

WPcom tests are passing now: D140622-code

> I'm wondering about passing that deprecated class to the feedback post type [here](https://github.com/Automattic/jetpack/blob/a244c2791cbe5b2a213016ebba34aa90832cc341/projects/plugins/jetpack/modules/contact-form/grunion-contact-form.php#L370), should we replace it with `Contact_Form_Endpoint?`? I'd like to keep logging the deprecation warnings for the...

Thanks for spotting this @sergeymitr. I should have double checked 🤦

> Do you see it on all pages of wp-admin right now? It's present on the window object in both the Jetpack and My Jetpack pages but not the other...