jetpack icon indicating copy to clipboard operation
jetpack copied to clipboard
verified publisher icon Automattic

Contact Form: refactor editor to use forms package

Open monsieur-z opened this issue 2 years ago • 2 comments

Proposed changes:

As part of the Contact Form module deprecation, this PR refactors the Grunion_Editor_View class to reference the Forms package.

Other information:

  • [ ] Have you written new tests for your changes, if applicable?
  • [ ] Have you checked the E2E test CI results, and verified that your changes do not break them?
  • [ ] Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Project thread: pf5801-Aj-p2 Issue: https://github.com/Automattic/jetpack/issues/35653

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

Let's do some regression testing.

  • Spin up a test site with this branch
  • Update the file /projects/plugins/jetpack/modules/contact-form.php so the condition on line 33 returns false. This ensures we're loading the Contact Form module.
  • Create a new post
  • Check you can still add a Contact Form block and that nothing breaks

monsieur-z avatar Feb 29 '24 20:02 monsieur-z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/contact-form-module-editor branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/contact-form-module-editor

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions[bot] avatar Feb 29 '24 20:02 github-actions[bot]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • :white_check_mark: Include a description of your PR changes.
  • :white_check_mark: Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • :white_check_mark: Add testing instructions.
  • :white_check_mark: Specify whether this PR includes any changes to data or privacy.
  • :white_check_mark: Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation :robot:

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged. If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen daily.
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for April 2, 2024 (scheduled code freeze on April 1, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

github-actions[bot] avatar Feb 29 '24 20:02 github-actions[bot]

I replaced return true with return false as instructed, and couldn't get the form to display.

Screenshot 2024-03-08 at 16 39 27 Clicking the button sends a request to `jetpack/v4/module/contact-form/active`, which returns the "was activated" response, but it doesn't change anything.

I was testing on a JN site with Jetpack Beta if that matters.

sergeymitr avatar Mar 08 '24 21:03 sergeymitr

I replaced return true with return false as instructed, and couldn't get the form to display.

@sergeymitr, I realize my instructions may have been confusing. The condition should be falsy, or the whole block can be commented out. Screenshot 2024-03-11 at 2 47 45 PM

monsieur-z avatar Mar 11 '24 18:03 monsieur-z

Sorry @sergeymitr, I noticed an error and had to push another commit: https://github.com/Automattic/jetpack/pull/36089/commits/b3aaf6be0f73508ba898699a799a278437e4ff28

monsieur-z avatar Mar 11 '24 20:03 monsieur-z