Nik Krimm

Results 59 comments of Nik Krimm

@megawac Thanks for the quality feedback. Updated diff addresses: - use restArgs - don't use `this` keyword, use direct reference - Clarified comment and token in response to Question: "is...

Thanks for this report, I'll look into it.

Interesting. Thanks for the well written report. Let me look into this for a bit and I'll update you.

@scr4bble Thanks for raising this issue. I will add an option to disable gzip.

Hi @SimonPNorra I haven't worked with any circuit breaker implementations yet. Sounds interesting, can you elaborate on what you'd need express-http-proxy to do in order to support you? Thanks

Currently, the library does not add any headers, but rather simply copies the headers from the req object passed to it. I can't tell if your concern is its not...

Interesting. I'm going to dig in a little and see if I can compose a useful standard set that could be added optionally for authors. Do you mind if I...

Interesting. Content-length is not copied (in either direction) because the author can modify the body. When sending the user response, we compute content-length directly and re-add, but looks like we...

req.params contains route parameters (in the path portion of the URL), and req.query contains the URL query parameters (after the ? in the URL). Are you saying you'd like to...

@magic-mohit @valecarlos Unless I'm misunderstanding you, `proxyReqPathResolver` allows you to operate on the query params before the request is sent to the proxy server. It is documented here https://github.com/villadora/express-http-proxy#proxyreqpathresolver-supports-promises, and...