underscore icon indicating copy to clipboard operation
underscore copied to clipboard

[#2286]: Underscore could use a _.propertyResult

Open monkpow opened this issue 9 years ago • 5 comments

I chose the name _.method per the above suggestion, but am happy to adjust if this does not match the project guidelines.

Fixes #2286

monkpow avatar May 05 '16 15:05 monkpow

Coverage Status

Coverage increased (+0.03%) to 96.894% when pulling 10bc63eb35b9709576a29ddf1f35e588ffd304a0 on monkpow:master into 53086b0f9f6cb4e2fb4eede82b4ef9f74bca030a on jashkenas:master.

coveralls avatar May 05 '16 15:05 coveralls

Coverage Status

Coverage increased (+0.03%) to 96.894% when pulling 037d5a8c9eb3c7a1e20e94848792eae5d52db7cc on monkpow:master into 53086b0f9f6cb4e2fb4eede82b4ef9f74bca030a on jashkenas:master.

coveralls avatar May 05 '16 19:05 coveralls

@megawac Thanks for the quality feedback. Updated diff addresses:

  • use restArgs
  • don't use this keyword, use direct reference
  • Clarified comment and token in response to Question: "is this not valid when a function is provided?". Added narrative above in this thread.
  • check if value is a function in the outer function.

monkpow avatar May 05 '16 19:05 monkpow

fyi lodash/method.

jdalton avatar May 05 '16 19:05 jdalton

Coverage Status

Coverage increased (+0.02%) to 96.891% when pulling 3fa1ae3bc43045efed263d78754c050fd6cfe000 on monkpow:master into 53086b0f9f6cb4e2fb4eede82b4ef9f74bca030a on jashkenas:master.

coveralls avatar May 06 '16 14:05 coveralls