Max Schmeller

Results 9 comments of Max Schmeller

I fourth this! It is really hard to find examples covering large parts of the API, you seem to have done it all. :+1:

@StepTurtle Thank you for your PR! Thank you especially for the easy-to-follow PR description and documentation. @Shin-kyoto > * Add unit tests and ensure that they pass in CI. >...

@StepTurtle Thank you for the great work! I've had a look and I think all of my feedback has been addressed :partying_face: I'm not one of the main reviewers so...

@yukkysaito > Could you please designate a person from the Sensing team to verify the algorithm's validity, as I haven't had enough time to fully review it? I'll take over!

@veqcc CPPcheck [failed](https://github.com/autowarefoundation/autoware.universe/actions/runs/11097207598/job/30828078728?pr=8380) on a file that has not been touched by this PR. How to best handle such a case?

@vividf Sorry, applying suggestions through GitHub seems to have wrecked DCO: [it's failing](https://github.com/autowarefoundation/autoware.universe/pull/8380/checks?check_run_id=31012760538). Could you rebase as suggested in that failing check? :bow:

@mitsudome-r @youtalk @xmfcx Hi, the CUDA build is [failing](https://github.com/autowarefoundation/autoware_universe/actions/runs/15458796550/job/43519969726#step:9:30) on `Get modified packages` for no obvious reason, would one of you mind taking a look? I already tried re-running multiple...

@badai-nguyen @drwnz Please have a look when you find the time :bow:

@badai-nguyen Thank you for the review! I've addressed your feedback and rebased. Could you @badai-nguyen and/or @drwnz have another look? :bow: