Benedikt McMullin
Benedikt McMullin
rebased to fix conflicts with master and address the last comment, though in a slightly different way. (one of the problems got fixed independently in the mean time)
I'm fine with a submenu if you're willing to have multiple versions of this tweak. (and maybe someone comes up with another one in the future) I do think having...
1. Moved footnote extension to submenu 2. Fixed "smaller" variants of in-page footnotes in the presence of extended footnotes. I think the fix for (2) is somewhat dependent on order...
Marked as non-draft on the basis that I think https://github.com/koreader/crengine/pull/618 is pretty much ready.
@Commodore64user replying to you here instead of https://github.com/koreader/koreader/pull/13613#issuecomment-2812358410 to keep the discussion more focused. > [...], although the `extension` stuff could go inside `fix-up` easily. Just add a separator and...
Well, my head didn't read those as a choice so it was a bit long. (and maybe I made a copy&paste mistake) :sweat_smile: Obviously fits with your wording and is...
I've rebased out the footnote extension changes, let's keep that discussion in #13554. Just means I'll need to rebase whichever one of these is merged first.
Pushed an alternative that allows getting rid of "smaller" while keeping all current behavior/combinations in #13639. Not sure if it's worth it though or if this simplification is enough.
Good point, will look into migrating per-book settings as well. (and fix the hint name) --- In the mean time, thoughts on either of these menu placements? (and of course...
Sorry, I should have elaborated a bit more. I pushed the left version without the wording change. I just moved the "smaller footnotes" hint, which is ``` *, autoBoxing {...