Benedikt McMullin

> No idea if the migration will handle all cases, or prevent some combinations (smaller FB2 but normal EPUB ? probably rarely used), so trusting you. I tested many different...

`settings_migration` handles global and per-book settings. I switched to using that and this branch now handles both correctly (that's where the `false` cases in the migration table come from, global...

I think you got it all correct. Another reason why I think it's quite safe is that the book I've mainly used for testing actually has infinite recursion and this...

these two just assign the pointer and to the best of my knowledge are identical: ``` LVFootNoteList * notes = line->getLinks(); LVFootNoteList * notes{line->getLinks()}; ``` These two are also identical,...

> So, if on a line we get footnote number 20 and 21 - and if 20 has nested footnotes 33 and 34, we will show at the bottom of...

> So, if on a line we get footnote number 20 and 21 - and if 20 has nested footnotes 33 and 34, we will show at the bottom of...

Thanks again. I'll be off for a few weeks to hopefully get some reading done :grin: --- Slightly off-topic here, but not sure where else to ask (gitter?) I have...

Hi, just checking if there's anything I can do to push this over the line. For what it's worth I've not found any problems with it so far, and I've...

Moved to `-cr-only-if: line-height-normal`, as suggested in https://github.com/koreader/koreader/pull/12483. It's a bit annoying that the parent style needs to be passed through everywhere, but it's all coming from `lvrend`'s `setNodeStyle`, which...

> These are really 2 different things: LVCssDeclaration::parse parses a stylesheet way earlier before we get to act on nodes. Which is what setNodeStyle does: applying. Sorry, I got that...