Moritz Firsching comments

Results 226 comments of


                                            Moritz Firsching

Permit argument bundling in the CLI tools

In the replacements cjxl_ng and djxl_ng, the flags have different behavior, so closing this, since it will not be relevant anymore pretty soon.

Failure to build tools/benchmark/benchmark_codec_avif.cc under Ubuntu 22.04 LTS

I suppose we should specify more precisely which version we require for building the benchmark

Failure to build tools/benchmark/benchmark_codec_avif.cc under Ubuntu 22.04 LTS

> This is a side effect of [5df155d](https://github.com/libjxl/libjxl/commit/5df155d975bd8ecf091f2b808d41cdd1f37e09b8). I could add an #ifdef guard for this, if necessary. yes, please, @Traneptora! Thanks for looking into it.

Bug

I had the impression that this was opened by mistake, so I closed it

Missing output file

Thanks for the report, @a84r7a3rga76fg. I cannot reproduce this. With a random .jpg image, it seems to work. Perhaps you could provide the `input.jpg` where this problem occurs?

Missing output file

Thanks for checking. That still seems like it might be a problem. Can you check with https://github.com/libjxl/libjxl/actions/runs/9795797489/artifacts/1668426988 ?

Releases are not reflecting main developments

We are planning to make a release soon

add more info to cmake output

@sboukortt good point! any suggestions for alternative phrasing?

When I convert a CMYK jpeg to jxl, cjxl raises error

djxl does not output extra channels for png

Working on a fix. Note that this already works for decoding to ppm and pfm.