Moritz Firsching
Moritz Firsching
I took the liberty to make a squashed rebase, so that only the 4 files that have been changed show up in the review here... This contains exactly the same...
rebasing once more, because https://github.com/libjxl/libjxl/pull/1903 just landed and that modifies the same files (this one was trivial to rebase, though..)
@jonsneyers I think we should move forward on this and even accept a version that can later be improved. Better to have slighly buggy animation support than none...
I plan to rebase and resovle the conflicts after https://github.com/libjxl/libjxl/pull/2190 is merged...
Can you check if this is still the case with version 10.1? We reduced the number of allocations, which could explain some of those speed differences.
I can confirm this: currently we only accept 1 or 3 color channels when reading jpgs: https://github.com/libjxl/libjxl/blob/6d1e6d26f6ce5b081410559f2fbbe44014e65dc5/lib/extras/dec/jpg.cc#L217 so CMYK JPEG are not supported: ``` ~/libjxl ((a50131aa…))> ./build/tools/cjxl -j 0 flower_small.cmyk.jpg...
Thanks for the report, @mxdpeep When following https://github.com/libjxl/libjxl/blob/main/BUILDING.md, should ``` sudo apt install clang ``` already bring in some version of `libstdc++-12-dev` as a dependency? Did you follow that or...
@rubyFeedback Thanks for the feedback. Just to understand better: Did you clone with the `--recursive` flag or ran `git submodule update --init --recursive` later to get the submodules?
Thanks! I can reproduce the issue. When viewing `text.jxl` in a patched Chrome, which is able to play animations, I also see the artifacts, so it seems that the problem...
> Thanks for the answer. What would happen if one would read a R,G,B,Optional,Alpha image with format.num_channels = 4 : would it extract the the second extra channel (I assume...