Marija Najdova

Results 224 comments of Marija Najdova

> well if all the components use the theme context it's kindof unavoidable All styled components would need to be marked, as they all depend on Emtion's context.

We haven't been actively working on v4 for over a year. Is it happening with v5 too? Edit: Ok, I can reproduce on v5, marking this as bug.

> I don't understand your point on this, can you elaborate? I just meant that the blue icons look weird on the red background :)

> I try to avoid adding more props for this. There are some use cases where color inversion does not need to be enabled by default for popups. > This...

Let's keep it as is for now, we can see if there are valid use-cases of my point from above.

@evanbrooks0629 where are these color pallets coming from? The colors we have are the ones defined in the spec: https://m2.material.io/design/color/the-color-system.html#tools-for-picking-colors

Thanks for looking into this. I would probably make the background a bit lighter in light mode. Also, could you please add a regression test for this? Using the codsandbox...

> Looks like these changes affect both light and dark modes, should this be improved in v6? @mnajdova Good point, maybe we should focus on changing only dark mode in...

@michaldudak if we want to move forward with this, I suggest someone from the core team take care of it. Do all the changes necessary and merge the PR right...

Great work @kabernardes btw :)