material-ui icon indicating copy to clipboard operation
material-ui copied to clipboard

fix: adapt button colors when contained+inherit

Open jesrodri opened this issue 1 year ago • 6 comments

co-authored: @EduardoSCosta

This PR resolve #29749

image image

jesrodri avatar Sep 28 '22 21:09 jesrodri

Netlify deploy preview

https://deploy-preview-34508--material-ui.netlify.app/

@material-ui/core: parsed: +0.08% , gzip: +0.05%

Bundle size report

Details of bundle changes

Generated by :no_entry_sign: dangerJS against 5abef5af3e2261f85cf64a93111c24ae5db4c610

mui-bot avatar Sep 28 '22 21:09 mui-bot

@danilo-leal @mnajdova could you guys take a look at this please?

jesrodri avatar Nov 07 '22 22:11 jesrodri

I will take a look at this tomorrow! thanks for the fix.

siriwatknp avatar Nov 09 '22 10:11 siriwatknp

Thanks for looking into this. I would probably make the background a bit lighter in light mode. Also, could you please add a regression test for this? Using the codsandbox linked in the issue can be a great start: https://codesandbox.io/s/togglecolormode-material-demo-forked-1j544?file=/demo.js You can add the fixture here: https://github.com/mui/material-ui/tree/master/test/regressions/fixtures/Button

mnajdova avatar Nov 10 '22 13:11 mnajdova

Looks like these changes affect both light and dark modes, should this be improved in v6? @mnajdova

Good point, maybe we should focus on changing only dark mode in this PR.

mnajdova avatar Nov 16 '22 10:11 mnajdova

Hey @siriwatknp @mnajdova @danilo-leal , I'm Jessica's friend and will be dealing with this PR for now on :) I've added the regression test based on MultilineButton and the demo you guys pointed above, hope I get it right. I've also changed the dark mode color to darker and the light mode to lighter

image image

Mention me for futher feedback :) Thanks!

feliperli avatar Dec 07 '22 19:12 feliperli