Emmanouil Theofanis Chourdakis comments

Results 20 comments of


                                            Emmanouil Theofanis Chourdakis

Improve consistency: min_gain_db vs. min_gain_in_db

I would be in favour of `min_gain_db` since it provides exactly the information needed (minimum, a gain value, in db unit).

Establish a common pattern for post-gain

I like the idea of a GainCompensation transform.

Establish a common pattern for post-gain

That works too. Alternative names: `AudioBus` or `Fader`

Move changelog from README.md to CHANGELOG.md

I agree with @atamazian. Alternatively, to not lose content in README.md we can use: collapsible markdown: https://gist.github.com/joyrexus/16041f2426450e73f5df9391f7f7ae5f

Fix freeze_parameters in Compose and SpecCompose

Could you provide a little bit more info on that? What is the problem?

Improvements in _get_verb_matches

Hi It's been so long since I built it that I don't really remember why I did it like that. You might be right that it's better that way. You...

Improvements in _get_verb_matches

Closing this as inactive.

fix negation phrase verbs

Hi, Thank you for your PR. Could you tell me a bit more what this PR is about? What was the problem before and what is the PR fixing? Also,...

fix negation phrase verbs

Closing this as inactive.

Remove insignificant test assets

> 2. `GTZAN` dataset does not have the list of files that corresponds to the entire dataset. Since `GTZAN` has a fixed number of samples, it should not be traversing...