audiomentations icon indicating copy to clipboard operation
audiomentations copied to clipboard

Fix freeze_parameters in Compose and SpecCompose

Open iver56 opened this issue 3 years ago • 2 comments

When parameters are frozen in a Compose or SpecCompose:

  • don't re-roll random number for p
  • don't reshuffle transforms

iver56 avatar Oct 29 '21 07:10 iver56

Could you provide a little bit more info on that? What is the problem?

mmxgn avatar Mar 01 '22 14:03 mmxgn

It randomizes "should_apply" (based on p), and it has the power to shuffle transforms, but it currently doesn't remember the value of "should_apply" and the shuffled order of transforms inside self.parameters. The idea is that calling freeze_parameters() will make it behave the same next time it gets called (so the same collection of transforms can be applied to another sound). This hasn't been properly implemented in Compose and SpecCompose yet

iver56 avatar Mar 01 '22 14:03 iver56